Improve LDAP performances when updating records, especially when many user entries exists #1975
+104
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
With 150 users and 12 apps, a
yunohost user create
take 1minWith 350 users and ~25 apps, a
yunohost user create
take hours maybe days.Solution
Replace
ldap.modlist.modifyModlist
by an optimize code that work for yunohost.Test in a dev platforme (with ssd 600Mbps) : the 169th user creation is made in ~3s.
PR Status
Need more test to be sure it doesn't break something...
How to test